Simplify User component when we have auth #124
+191
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RhysMAdey
reviewed
Jan 28, 2026
| }; | ||
|
|
||
| it("should render", () => { | ||
| renderWithProviders(<User auth={authDummy} />); |
Collaborator
There was a problem hiding this comment.
do we need any assertions after this to check its rendered?
Member
Author
There was a problem hiding this comment.
I just put these in to test the testing system and to test the component doesn't crash, etc.
It doesn't need to test the specifics of the implementation of User, as that's what the subsequent tests do.
Collaborator
|
Other than the one comment above looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting each parameter individually, we can just pass in auth from useAuth.
This also adds an extra menu item to the User menu so that users can see their Keycloak profile page.